Skip to content

build: T9140: include version and flavor information in the boot menu - #1255

Merged
asklymenko merged 1 commit into
vyos:rollingfrom
dmbaturin:T9140-boot-menu-version-flavor
Jul 30, 2026
Merged

build: T9140: include version and flavor information in the boot menu#1255
asklymenko merged 1 commit into
vyos:rollingfrom
dmbaturin:T9140-boot-menu-version-flavor

Conversation

@dmbaturin

@dmbaturin dmbaturin commented Jul 28, 2026

Copy link
Copy Markdown
Member

Change summary

Include version and flavor information in the live image boot menu so that people can instantly see what image they are booting.

Screenshot_VyOS-test-1_2026-07-28_18:18:24

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 71c7e181-7a3a-47eb-b1ad-5ca562ce21de

📥 Commits

Reviewing files that changed from the base of the PR and between c2544eb and a3b7ace.

📒 Files selected for processing (1)
  • scripts/image-build/build-vyos-image
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • ansible/ansible (manual)
📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: build_iso
  • GitHub Check: codeql-analysis-call / Analyze (python)
  • GitHub Check: Mergify Merge Protections
  • GitHub Check: Summary
🧰 Additional context used
🔍 Remote MCP vyos.dev
  • T9140 is titled “Include version and flavor information in the live image boot screen”. It is Open, Low priority, and classified as a feature. The task description says the current live image boot screen only shows the release series, and the goal is to add image-identifying version/flavor info at build time.
  • The task belongs to the VyOS Rolling project and is currently on the Need Triage board. There are no comments on the task.
🔇 Additional comments (1)
scripts/image-build/build-vyos-image (1)

497-510: 🎯 Functional Correctness

No GRUB menu update is needed here. scripts/image-build/build-vyos-image:497-510 only writes includes.binary/isolinux/menu.cfg; the live-build tree under data/live-build-config/bootloaders/grub-pc/grub.cfg is a static GRUB template, not a separate versioned UEFI menu source.

			> Likely an incorrect or invalid review comment.
📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • ISO images now include an enhanced boot menu displaying the effective VyOS version and build flavor.

Walkthrough

The image build script now generates menu.cfg with the effective VyOS version and build flavor, then writes it into the live-build isolinux configuration directory.

Changes

ISO boot menu generation

Layer / File(s) Summary
Generate and write boot menu
scripts/image-build/build-vyos-image:497-511		 build() constructs an isolinux menu configuration from build_config['version'] and build_config['build_flavor'], then writes it under defaults.LB_CONFIG_DIR/includes.binary/isolinux/menu.cfg.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title matches the main change: adding version and flavor details to the boot menu.
Description check ✅ Passed Description accurately describes the boot menu version/flavor update and is aligned with the patch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the rolling label Jul 28, 2026
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

CI integration 👍 passed!

Details

CI logs

  • Config tests 👍 passed

sever-sever
sever-sever approved these changes Jul 29, 2026
View reviewed changes

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add version and flavor type to the boot menu

@mergify

mergify Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

asklymenko
asklymenko approved these changes Jul 30, 2026
View reviewed changes

@asklymenko asklymenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display version in boot menu.

@asklymenko
asklymenko merged commit 8d1faab into vyos:rolling Jul 30, 2026
15 checks passed
@vyos-bot vyos-bot Bot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sever-sever sever-sever sever-sever approved these changes
@asklymenko asklymenko asklymenko approved these changes
@hedrok hedrok Awaiting requested review from hedrok
@jestabro jestabro Awaiting requested review from jestabro
@c-po c-po Awaiting requested review from c-po
@natali-rs1985 natali-rs1985 Awaiting requested review from natali-rs1985

Assignees

@dmbaturin dmbaturin

Labels

mirror-completed rolling

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmbaturin @sever-sever @asklymenko